Update adsorption corrections#13
Open
kirkbadger18 wants to merge 8 commits intofranklingoldsmith:mainfrom
Open
Update adsorption corrections#13kirkbadger18 wants to merge 8 commits intofranklingoldsmith:mainfrom
kirkbadger18 wants to merge 8 commits intofranklingoldsmith:mainfrom
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here I changed how the structure of the tree is stored and read. Before there was a folder called that had a file for each node in the tree, and in each file was a list of species attached to that node and all nodes below. Here I created a class called "Node" and expanded out the tree as a set of nested Node objects in tree.py. species are attached to the node in this tree at the lowest level for which they show up. This means that each species only needs to be types out once and exist only in tree.py
Additionally, I added the nitrogen tree data and modified the IO scripts.