feat: redone Framework integration#604
Draft
safwansamsudeen wants to merge 38 commits into
Draft
Conversation
chore: rename more fields
Collaborator
Author
|
@federicocalvo @nilpatel42 please let me know if you're interested in alpha testing 😄 (DM @realsafwan). |
|
This should be a real game-changer in terms of encouraging the use of the drive |
…th (D1)
Notable decisions:
- Took ff-file's framework File doctype model throughout (file_name/is_folder/
file_url over Drive File's title/is_group)
- Adopted develop's structured frappe.local.response.errors pattern in
get_entity_with_permissions
- Adopted develop's delayedLoading watcher in DriveToolBar
- Adopted develop's Tooltip wrappers for share_count icons in ListView
- Kept ff-file's reactive storage-bar watch over develop's one-shot fetch
- Dropped DocEditor (deleted in develop) and the editor-style imports in
utils/files.js and utils/download.js
- Took yarn over pnpm and frappe-ui npm 0.1.269 over the github pinned commit
- Switched newExternal Presentation flow to develop's /slides/presentation/new
redirect; drive.api.files.create_presentation is now unreachable
- Restored develop's frappe_doc/markdown branch in getLink (was missing in HEAD)
D1: scripts.clear_deleted_files used today + timedelta(30); flipped to today -
timedelta(30) so the job preserves status=-1 records for 30 days before
hard-delete instead of nuking them on first run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge
Drive FileintoFile. Makes Drive the improved file-viewer for Framework.