fix(modal): disable button and update styles based on selection#552
Open
yakupafsin wants to merge 2 commits intofreeCodeCamp:mainfrom
Open
fix(modal): disable button and update styles based on selection#552yakupafsin wants to merge 2 commits intofreeCodeCamp:mainfrom
yakupafsin wants to merge 2 commits intofreeCodeCamp:mainfrom
Conversation
Contributor
|
Just ran it in my development environment and it seems to be working fine! Only issue I can see is that the snapshot used in testing is not up to date with the new change. |
Author
|
Hi, @NewtonLC, thanks for review. It's ready to merge! |
Contributor
|
Hi @yakupafsin! I don't have full permission to approve changes, but I'll make sure this gets looked at by a maintainer early next week. Just wanted to let you know there may be a short delay. |
Contributor
|
Hi @yakupafsin, the Edit Class modal (the modal that appears when you click "Edit Classroom") still uses the old behavior. Could you change it to have the same behavior that you implemented in modal.js? The Edit Class modal seems to be located in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Update index.md)Closes #551