fix: recycle gateway transient/courtesy links #2067
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanity
force-pushed
the
stack/connect-transport-rewrite
branch
from
ead6ba4 to
d3318b5
Compare
sanity
force-pushed
the
courtesy-connection-budget
branch
from
b2f244f to
a17fa5b
Compare
sanity
changed the title
sanity
force-pushed
the
stack/connect-transport-rewrite
branch
5 times, most recently
from
7bac7e5 to
c518296
Compare
sanity
force-pushed
the
courtesy-connection-budget
branch
from
a17fa5b to
0c91f8a
Compare
iduartgomez
force-pushed
the
stack/connect-transport-rewrite
branch
from
c67b254 to
f2a9734
Compare
sanity
force-pushed
the
stack/connect-transport-rewrite
branch
from
f2a9734 to
2b64641
Compare
sanity
changed the title
sanity
force-pushed
the
courtesy-connection-budget
branch
from
0c91f8a to
8cac58b
Compare
- Remove unused std::fmt import from p2p_protoc - Update connection_manager calls to match current API - Fix clippy warnings (collapse else-if blocks) - Remove unused import from ring module Part of ongoing merge conflict resolution with main. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
sanity
force-pushed
the
courtesy-connection-budget
branch
from
6b671e3 to
9ea33b1
Compare
Collaborator
Author
|
Closing in favor of fresh approach with separate transient connection tracking. The original implementation modified existing connection logic and triggered 'connection already exists' errors. After analysis, a cleaner design emerged: maintain transients in a separate registry completely distinct from connections_by_location. New PR will follow with this approach, building on lessons learned here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Draft – still instrumenting and validating transient connection cleanup; see AGENTS.md for context.
Summary
Temporary gateway connections now
Next steps: finish the transient-upgrade lifecycle and re-run the 50-peer River stress test once the handshake race is addressed.
Terminology note: We should standardize on the term "transient" rather than "courtesy" - which was used in #2065, please change this wherever you find it.