up#2
Open
sambacha wants to merge 215 commits into
Open
Conversation
Add Construction API (formerly Wallet API)
Signed-off-by: Henry Yang <yhenry@gmail.com>
Add hash case sensitivity to the spec
* Update CONTRIBUTING.md file * Post-review edits to contributing.md * Post-review update of CONTRIBUTING.md file
* Update README and CONTRIBUTING files These updates should facilitate contributions by developers. * Edit README file formatting and text * Update formatting in README file * Update CONTRIBUTING file after feedback * Post-peer updates to CONTRIBUTING.md file * Post-review updates to README.md * Edit formatting at top of README file * Formatting update for README.md
Fix rosetta-cli link to correct repo
* replace CircleCI with gh actions * Update license script
remove public key in metadata
[metadata]add public key back
[preprocess]remove max_fee and mulltiplier in preprocess request
This endpoint provides fallback parsing for high-level transaction construction operations when local OperationSelector doesn't support certain construct operations. Features: - Input format matches TransactionConstructOpInput from chainstdio - Output format matches ParseTransactionConstructOp return values - Optional API (servers can return 501 Not Implemented) - Full OpenAPI specification with request/response schemas - Maintains compatibility with existing operation parsing workflows Endpoint: POST /construction/preprocess_operations Request: ConstructionPreprocessOperationsRequest Response: ConstructionPreprocessOperationsResponse
* Add AllAccountBalances API and fix URL naming consistency This commit introduces two key enhancements: 1. AllAccountBalances API: - Added POST /account/all-balances endpoint - Consolidates multiple sub-account balance queries into single request - Ensures consistent block context for all balances - Added AllAccountBalancesRequest, AllAccountBalancesResponse, and AccountBalanceWithSubAccount schemas - Removed root-level metadata from AllAccountBalancesResponse (metadata belongs to individual sub-accounts) 2. URL Naming Consistency: - Changed /construction/preprocess_operations to /construction/preprocess-operations - Maintains kebab-case convention across all Rosetta endpoints - Updated both endpoint path and description references Benefits: - Reduced network latency (single request vs multiple) - Improved data consistency (same block context) - Backward compatible (existing /account/balance unchanged) - Optional implementation for Rosetta servers Files modified: - api.yaml: Added new endpoint and schemas, fixed URL naming - api.json: Regenerated specification bundle * Remove SubAccountIdentifier field from AccountBalanceWithSubAccount schema - Remove sub_account_identifier field from AllAccountBalancesResponse - Update descriptions to reflect that balance identification relies on balance_type and metadata - Simplifies API by removing redundant field that is rarely used in practice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Motivation
Solution
Open questions