Delegate DirFileSystem delete and write_text#2022
Merged
martindurant merged 2 commits intofsspec:masterfrom Apr 29, 2026
Merged
Delegate DirFileSystem delete and write_text#2022martindurant merged 2 commits intofsspec:masterfrom
martindurant merged 2 commits intofsspec:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DirFileSystem.delete()to the wrapped filesystem instead of inheriting the base alias pathDirFileSystem.write_text()so wrapper filesystems can enforce their own write behaviorCloses #1997.
Validation
fs.write_text('bar', 'lorem ipsum')andfs.delete('bar')to succeed instead of raising from the wrapped filesystem.HEADworktree with only the new tests applied:.venv/bin/python -m pytest fsspec/implementations/tests/test_dirfs.py -k 'delete or write_text' -q4 failed, 134 deselected.venv/bin/python -m pytest fsspec/implementations/tests/test_dirfs.py -q138 passedNotImplementedErrorfor bothwrite_textanddelete, proving delegation reaches the wrapped filesystem.fsspec/implementations/dirfs.pyandfsspec/implementations/tests/test_dirfs.py.