Appending 'DeleteMarkers' in returned object versions#981
Open
didacarbones wants to merge 1 commit intofsspec:mainfrom
Open
Appending 'DeleteMarkers' in returned object versions#981didacarbones wants to merge 1 commit intofsspec:mainfrom
didacarbones wants to merge 1 commit intofsspec:mainfrom
Conversation
martindurant
reviewed
Aug 6, 2025
Member
martindurant
left a comment
martindurant
left a comment
There was a problem hiding this comment.
If moto supports this, it would be nice to have a test - we do have versioned bucket tests.
| ) | ||
| versions.extend(out["Versions"]) | ||
| if "DeleteMarkers" in out: | ||
| versions.extend(out["DeleteMarkers"]) |
Member
There was a problem hiding this comment.
out["DeleteMarkers"] is a dictionary? Can you please link to the AWS documentation on this.
Member
|
ping - any update here? |
Author
|
Sorry for the delay. I need to allocate some time to loo at the repo and how to add the tests. |
Member
|
This got pretty old - do you plan to come back to it and add a test? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing issue #980