Skip to content

GitLab: pin the runner image to fullsend_ref instead of tracking main (:dev) #8865

Closed

Description

@waynesun09

What happens

The GitLab CI scaffold pulls the runner image from main, even when the project pins a fullsend release:

  • fullsend-agent.yml:108, fullsend-dispatcher.yml:31 and fullsend-poll.yml:12 (under internal/scaffold/fullsend-repo-gitlab/.gitlab/ci/) all use ghcr.io/fullsend-ai/fullsend-runner:dev.
  • runner-image.yml moves dev on every main push that touches images/runner/**, openshell-version.sh, go.mod/go.sum or the workflow.
  • gitlab.fullsend_ref pins only the CLI. install-fullsend-cli.sh receives it through the __FULLSEND_VERSION__ placeholder; the image is not templated.

So a GitLab project on a release runs that release's CLI with whatever OpenShell, gh, gitleaks, pre-commit, Go and gcloud main last built. GitHub users get the action and tools of the tag they pin.

This is how the OpenShell 0.1.4 bump (#8299) reached every GitLab runner within the hour, with no release or user action (#8564). #8566 now lets the runner VM install the job image's OpenShell version, so that exact failure should not recur. The release mismatch remains: a project pinned to an older release still gets main's OpenShell, and the next one is close, since Renovate #8738 (OpenShell 0.1.5) is open. When it merges, every GitLab install moves to 0.1.5 at once, before any release is tested with it.

:dev was introduced by #6483 "as a temporary measure until the scaffolds can be updated to pin a specific release version". Nothing outside the GitLab scaffold pulls fullsend-runner:dev; the GitHub action does not use the runner image.

What should happen

Before GitLab is announced as production-ready, the runner image should follow fullsend_ref:

  • A release ref (the default) renders ghcr.io/fullsend-ai/fullsend-runner:X.Y.Z into all three templates, using the same renderer that fills __FULLSEND_VERSION__ (internal/scaffold/installfiles.go, internal/repos/remote_scaffold.go). fix(#8564)!: let GitLab runners serve multiple OpenShell pins #8566 already verifies that a release-tagged image's revision matches the vX.Y.Z tag.
  • latest should resolve to a concrete release at install time, or be documented as tracking releases, not main.
  • Tracking main stays possible only as an explicit opt-in for maintainers and early testers (for example a runner_image: dev setting), not the default. An untagged commit ref cannot map to an image automatically, because the image is built only for commits that touch the runner paths.
  • repos status / convergence should report drift when the rendered image tag and fullsend_ref disagree, so existing trial installs are upgraded by repos install.
  • Docs (configuring-gitlab.md, hack/gitlab-runner-vm/README.md) state which image a project runs and how it changes on upgrade.

Acceptance checks

  • A fresh install pinned to a release renders the matching fullsend-runner:X.Y.Z in the agent, dispatcher and poll templates.
  • Merging a runner-image change to main does not change the image a release-pinned GitLab project runs.
  • Upgrading fullsend_ref re-renders the image tag in the same convergence run.
  • The dev opt-in still works and is called out as unsupported for production.

Timing

Ideally this lands before #8738 merges; otherwise #8738 ships OpenShell 0.1.5 to GitLab trial installs straight from main.

cc @ggallen — this blocks calling GitLab production-ready. Your call on timing relative to #8738 and the open GitLab work.

Related: #6483, #8564, #8566, #8730, #8738.

Activity

  1. fullsend-ai-triage commented on Oct 27, 2026

    @fullsend-ai-triage

    🤖 Finished Triage · ✅ Success · Started 3:38 PM UTC · Completed 3:40 PM UTC

    Commit: ea70926 · View workflow run →

    Runtime: claude · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $0.19

  2. fullsend-ai-triage commented on Oct 27, 2026

    @fullsend-ai-triage

    Triage found this actionable as written. No existing PR or duplicate issue was found. Related #6483, #8564 and #8730 are closed and #8566 is merged. #8738 is still open and is a timing concern rather than a blocker.

    Fix targets verified in this repo: the :dev image reference is at the cited lines in the three GitLab CI scaffold templates. The version placeholder is rendered in internal/repos/remote_scaffold.go. internal/repos/gitlab_trigger_dispatch_gate.go also handles the marker for install-script comparison, so it will need to stay consistent with any new placeholder. The docs named in the issue both exist. The GitLab CI scaffolds are not GitHub workflow files, so the workflow-change limitation does not apply.

    Points for the implementer to settle:

    • Image tags are likely X.Y.Z without the v prefix that fullsend_ref carries. Confirm the tag format when templating.
    • Choose the opt-in setting name, for example runner_image: dev. Document it in the config reference, and also in the GitLab docs listed in the issue.
    • Decide how untagged commit refs behave without the opt-in: a clear error or warning is better than silently falling back to :dev.

    Proposed test case:

    Given fullsend_ref=vX.Y.Z -> all three templates render fullsend-runner:X.Y.Z (no placeholder, no :dev)
    Given runner_image=dev -> templates render :dev
    Given fullsend_ref=latest -> resolves to a concrete release tag
    Given an install with a stale image tag -> status reports drift; install with bumped ref re-renders in the same run
    Given a commit-SHA ref without opt-in -> error/warning, not silent :dev
    

    The issue asks the maintainer to decide timing relative to #8738. This triage does not make that call.


    Next steps:

    • /fs-code — agent creates a PR to implement this issue
    • /fs-code <your instruction> — agent implements with your specific guidance
  3. ggallen commented on Oct 27, 2026

    @ggallen
    Member

    /fs-code

  4. fullsend-ai-coder commented on Oct 27, 2026

    @fullsend-ai-coder
    Contributor

    🤖 Finished Code · ✅ Success · Started 11:47 PM UTC · Completed 12:10 AM UTC

    Commit: f3b9d98 · View workflow run →

    Runtime: claude · Model: opus → claude-opus-5-5 · Effort: high · Cost: $4.17

  5. added 2 commits that reference this issue on Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    triagedTriaged but awaiting human prioritization

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions