Added sorting keys before checking.#3
Open
artzub wants to merge 1 commit into
Open
Conversation
The reason is
```
const roles = [
{
roles: ['readonly'],
allows: [{
resources: ['/api/v1/user/.*'],
permissions: ['get'],
}],
},
{
roles: ['admin'],
allows: [
{
resources: ['/api/v1/user(/.*)?'],
permissions: ['get', 'put', 'post', 'delete'],
}
],
},
{
roles: ['superadmin'],
allows: [{
resources: '.*',
permissions: '*'
}]
}
];
```
Keys of buckets will be incorrectly sorted.
if make a request (role `admin` or `superadmin`):
`DELETE /api/v1/user/someid`
then `union` method will find a wrong `bucket`
`/api/v1/user/.*` that has just only one role `readonly`
but it is not expected behavior.
After keys sorting we have at least the needed `bucket` = `allows_/api/v1/user(/.*)?` or for superadmin `allows_.*`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason is
Keys of buckets will be incorrectly sorted.
if make a request (role
adminorsuperadmin):DELETE
/api/v1/user/someid,then
unionmethod will find a wrongbucket/api/v1/user/.*that has just only one rolereadonly,but it is not expected behavior.
After keys sorting we have at least the needed
bucket=allows_/api/v1/user(/.*)?or for superadminallows_.*