Skip to content

Conversation

@Smeds
Copy link
Contributor

@Smeds Smeds commented May 7, 2025

Needs API updates before it can be merged.

@Smeds Smeds marked this pull request as draft May 7, 2025 19:20
@Smeds
Copy link
Contributor Author

Smeds commented May 30, 2025

For this to work, we need the following galaxy pull-request 20359 to be merged.

@Smeds
Copy link
Contributor Author

Smeds commented May 30, 2025

@nsoranzo should I add some comment to the documentation that this function requires version XXX of galaxy?

assert len(step_jobs_summary) == 1
assert step_jobs_summary[0]["populated_state"] == "ok"

@test_util.skip_unless_galaxy("release_25.01")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@test_util.skip_unless_galaxy("release_25.01")
@test_util.skip_unless_galaxy("release_25.1")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will wait with adding this until I know at which release the dependent code change end up on.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, just noting that's the format we are currently using for releases.

@nsoranzo
Copy link
Member

@nsoranzo should I add some comment to the documentation that this function requires version XXX of galaxy?

Yes, please, that would be helpful! Example:

.. note::
This method works only on Galaxy 21.01 or later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants