fix: resolve all check-resolvable warnings (MECE, DRY, routing)#392
Closed
fix: resolve all check-resolvable warnings (MECE, DRY, routing)#392
Conversation
added 2 commits
April 24, 2026 08:22
- RESOLVER.md: broaden query triggers ("who is", "brain search",
"background on", "notes on this"), quote all citation-fixer triggers,
add disambiguation rules for citation-fixer vs maintain and
gbrain-jobs vs minion-orchestrator
- citation-fixer: add "citations are broken" and "fix broken citations"
triggers to frontmatter
- maintain: rename trigger "citation audit" → "maintenance audit" to
avoid MECE overlap with citation-fixer
- enrich: add convention delegation ref near notability tier table
(within DRY_PROXIMITY_LINES window), replace inlined citation format
rules with reference to conventions/quality.md
check-resolvable --skills-dir ./skills: 0 errors, 0 warnings
- RESOLVER.md: broaden query triggers ("who is", "brain search",
"background on", "notes on this"), quote all citation-fixer triggers,
add disambiguation rules for citation-fixer vs maintain and
gbrain-jobs vs minion-orchestrator
- citation-fixer: add "citations are broken" and "fix broken citations"
triggers to frontmatter
- maintain: rename trigger "citation audit" → "maintenance audit" to
avoid MECE overlap with citation-fixer
- enrich: add convention delegation ref near notability tier table
(within DRY_PROXIMITY_LINES window), replace inlined citation format
rules with reference to conventions/quality.md
check-resolvable --skills-dir ./skills: 0 errors, 0 warnings
garrytan
force-pushed
the
fix/resolver-warnings
branch
from
0c48010 to
19dbf15
Compare
…brain into fix/resolver-warnings
Owner
Author
|
Closing as won't fix — bad design. The PR shuffled trigger metadata across two systems that aren't the same thing (frontmatter triggers drive the MECE overlap check, RESOLVER.md tables drive structural routing, disambiguation prose drives nothing automated). Cleaning up the warnings this way papers over the structural gap rather than fixing it. Will revisit with a real routing contract. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes all 9 check-resolvable warnings. 4 files, +13/-12.
MECE overlap (citation-fixer + maintain):
maintaintrigger 'citation audit' → 'maintenance audit' (citation-fixer is the specific skill for citation work)DRY violations (enrich):
Routing misses (citation-fixer × 2, query × 3):
Verified:
check-resolvable --skills-dir ./skills→ 0 errors, 0 warnings.