fix: align gbrain extract --dry-run and doctor guidance with actual commands#397
Closed
vinsew wants to merge 1 commit into
Closed
fix: align gbrain extract --dry-run and doctor guidance with actual commands#397vinsew wants to merge 1 commit into
vinsew wants to merge 1 commit into
Conversation
7d1389a to
33c02bf
Compare
33c02bf to
f581c6f
Compare
5 tasks
Contributor
Author
|
Closing — superseded by #914. This PR can't cherry-pick onto current master. v0.32.8's multi-source threading (#860) reshaped both
#914 implements the same intent on the multi-source shape: per-extractor inline SQL that returns source ids alongside the link / timeline rows, cached per from-page, byte-for-byte key parity with the candidate side. 4 new tests in Thanks for the patience on this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small alignment fixes discovered while upgrading an existing brain from v0.14.2 to v0.20.4:
gbrain doctorstill tells users to run the retired command pairgbrain link-extract && gbrain timeline-extract— thegraph_coveragewarning message now points at the current canonical commandgbrain extract all --source db.gbrain extract --dry-runover-reports by counting every extracted candidate as a net-new row, even when the DB would reject it viaON CONFLICT DO NOTHING. The dry-run now caches existing outgoing links / timeline rows per source slug and filters candidates against that cache, so dry-run row counts match what a real run would actually insert.The link/timeline dedup keys used in dry-run now also carry
origin_page_id/origin_slugso frontmatter-derived edges from different origins don't collapse.Test plan
test/extract-db.test.tscase: dry-run output after a prior real-run reports zero net-new links (before this change it reported 1-to-1 with candidates).test/doctor.test.tsregression guard assertsdoctor.tssource containsgbrain extract all --source dband does NOT containgbrain link-extract && gbrain timeline-extract.bun testpasses the new cases on my setup.🤖 Generated with Claude Code