fix #47 P.either should fail with fatal error, if second parser faile…#48
Open
regevbr wants to merge 1 commit into
Open
fix #47 P.either should fail with fatal error, if second parser faile…#48regevbr wants to merge 1 commit into
regevbr wants to merge 1 commit into
Conversation
… failed with fatal, or should it?
Collaborator
|
Hey @regevbr - thank you very much for your work on this PR! However, in general, I would suggest that PRs be kept highly focused on whatever issue is being addressed. Otherwise it can be quite difficult to tease apart what the actual purpose of the PR was. Could you please trim down the PR to address only your suggestion relating to the In addition, I'm still not 100% sure if the semantics of using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit of a "big" PR, so I can split it if necessary.
After going through the entire library for educational purposes, I have came about many things I wanted to add/fix/test and I have came up with the following:
charC- a case insensitive char parser.stringC- a case insensitive string parser.oneOfC- a case insensitive one of strings parser.betweenparser to be able to provide 2 differentleftandrightparsersfatalif any wasfataland not if just the first one@gcanti please let me know how do you want to proceed here, I would appreciate any feedback :-)