Preserve zero input in Node API#2591
Open
vetrovk wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2590.
This change preserves numeric
0as valid input in the Node API instead of treating it as missing input.Changes:
0in Node API input normalization0inDishconstructionchef.toHex(0),chef.bake(0, ...),chef.ADD(0, ...), andnew Dish(0)falseValidation:
env PATH="/opt/homebrew/opt/node@24/bin:$PATH" npm cienv PATH="/opt/homebrew/opt/node@24/bin:$PATH" node --no-warnings --no-deprecation --openssl-legacy-provider tests/node/index.mjsenv PATH="/opt/homebrew/opt/node@24/bin:$PATH" npm run testnodeconsumerenv PATH="/opt/homebrew/opt/node@24/bin:$PATH" npm run lintgit diff --checkNotes:
v24.17.0and npm11.13.0.