Skip to content

Validate empty Show On Map options#2631

Merged
C85297 merged 1 commit into
gchq:masterfrom
vetrovk:fix/show-on-map-empty-options
Jul 3, 2026
Merged

Validate empty Show On Map options#2631
C85297 merged 1 commit into
gchq:masterfrom
vetrovk:fix/show-on-map-empty-options

Conversation

@vetrovk

@vetrovk vetrovk commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Fixes #2421.

This change rejects empty Show On Map input format and delimiter values through ingredient metadata validation, so empty options return normal validation errors instead of reaching internal coordinate parsing and leaking a TypeError.

Changes:

  • add allowEmpty: false to Input Format
  • add allowEmpty: false to Input Delimiter
  • add regression coverage for empty input format and empty delimiter with Auto format

Validation:

  • env PATH="/opt/homebrew/opt/node@24/bin:$PATH" npm ci
  • env PATH="/opt/homebrew/opt/node@24/bin:$PATH" npx grunt configTests
  • focused Show On Map operation test: 4/4 passed
  • full operation tests: 2058/2058 passed
  • env PATH="/opt/homebrew/opt/node@24/bin:$PATH" npm run lint
  • git diff --check

Notes:

  • Work was done in the clean checkout /Users/kirillvetrov/Documents/New project/CyberChef-2421 because the older CyberChef checkout has a corrupted remote ref.

@C85297 C85297 enabled auto-merge (squash) July 3, 2026 08:35
@C85297 C85297 merged commit d6f087e into gchq:master Jul 3, 2026
2 checks passed
@C85297

C85297 commented Jul 3, 2026

Copy link
Copy Markdown
Member

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(Show On Map): TypeError with an empty input format and input delimiter

2 participants