Skip to content

Comments

Add ToggleVisibilityAttribute for UI toggle switch support#24

Open
prestoncraw wants to merge 2 commits intodevelopmentfrom
OH-371
Open

Add ToggleVisibilityAttribute for UI toggle switch support#24
prestoncraw wants to merge 2 commits intodevelopmentfrom
OH-371

Conversation

@prestoncraw
Copy link
Contributor

Add ToggleVisibilityAttribute for UI toggle switch support.

Comment on lines 39 to 42
/// <summary>
/// Gets whether the property value should be reset to its default when the toggle is changed to the TriggerValue.
/// </summary>
public bool ResetOnTriggerValue { get; } = resetOnTrigger;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is actually required. otherwise what does the toggle do. And if it doesn't do anything to Connection string we wouldn't be able to figure out if it is on or off in the UI (on a fresh load)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants