Remove publishing android lib#1120
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the configurations for publishing the Android library to remote repositories like Maven Central and GitHub Packages, transitioning the workflow to local builds and consumption via mavenLocal(). The reviewer pointed out that the updated README is missing the specific Maven coordinates required for local integration and noted that the current build command only produces a debug variant, which may result in poor performance compared to a release build.
| Build the Gemstone Android AAR from source and publish it to the local Maven cache: | ||
|
|
||
| [libraries] | ||
| gemstone = { module = "com.gemwallet.gemstone:gemstone", version.ref = "gemstone" } | ||
| ```bash | ||
| just gemstone build-android | ||
| ``` | ||
|
|
||
| Add the following to your `build.gradle.kts` file: | ||
|
|
||
| ```gradle | ||
| dependencies { | ||
| api(libs.gemstone) | ||
| } | ||
| ``` | ||
|
|
||
| #### Maven Central (Recommended) | ||
|
|
||
| ```gradle | ||
| allprojects { | ||
| repositories { | ||
| mavenCentral() | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| #### GitHub Packages (Alternative) | ||
|
|
||
| Alternatively, you can use GitHub Packages (requires GitHub token): | ||
|
|
||
| ```gradle | ||
| allprojects { | ||
| repositories { | ||
| maven { | ||
| url = uri("https://maven.pkg.github.com/gemwalletcom/core") | ||
| credentials { | ||
| username = <github_username> | ||
| password = <github_token> | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ``` | ||
| Then consume it from `mavenLocal()` in your Android project. |
There was a problem hiding this comment.
The updated instructions for Android are missing the Maven coordinates (group, artifact, and version) required to consume the library from mavenLocal().
Additionally, the just gemstone build-android command currently only publishes the debug variant (as defined in gemstone/justfile), which uses the artifact ID gemstone-debug and version 1.0.0-debug (unless VER_NAME is set). Users should be informed of these coordinates and advised that Rust code in debug mode is significantly slower than release mode. Consider providing instructions or a command for the release variant as well (e.g., implementation("com.gemwallet.gemstone:gemstone-debug:1.0.0-debug")).
2 participants
No description provided.