Fix currency rate not applied on first price insert

[DRadmir]

The upsert doUpdate path (with rate conversion) only runs on conflict. On first insert, prices were stored in USD regardless of selected currency. Changed AssetPrice.record to accept rate parameter so both INSERT and UPDATE paths write correctly converted prices.

Fix: #1833

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where currency conversion rates were not being applied during the initial insertion of asset prices into the database, causing prices to be stored incorrectly in USD. By modifying the AssetPrice.record method to accept and apply a currency rate, and updating the PriceStore to pass this rate, the system now ensures that prices are accurately converted and stored in the selected currency from the very first record.

Highlights

• Currency Rate Application: The AssetPrice.record method was updated to accept a rate parameter, ensuring that the currency conversion is applied directly to the price during record creation.
• PriceStore Integration: The PriceStore.updatePrices function was modified to pass the retrieved currency rate to the assetPrice.record method, correctly applying the rate on both initial inserts and updates.
• New Test Case: A new test, firstInsertAppliesCurrencyRate, was added to PriceStoreTests to validate that currency rates are correctly applied when prices are first inserted into the database.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the AssetPrice.record property into a function record(rate: Double) to enable currency conversion during PriceRecord creation, ensuring the stored price reflects the converted value. The PriceStore.updatePrices method is updated accordingly, and a new test verifies this functionality. Feedback highlights two main points: the updatedAt field from AssetPrice is currently ignored when creating a PriceRecord, leading to nil on initial insertion, and there is a duplication of price calculation logic in PriceStore.swift that should be refactored for better maintainability.