fix: update logo URLs to /brand/ path#26
Merged
ErnestM1234 merged 2 commits intogeneraltranslation:mainfrom Mar 20, 2026
Merged
fix: update logo URLs to /brand/ path#26ErnestM1234 merged 2 commits intogeneraltranslation:mainfrom
ErnestM1234 merged 2 commits intogeneraltranslation:mainfrom
Conversation
ErnestM1234
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates README logo URLs from
generaltranslation.com/gt-logo-*.svgtogeneraltranslation.com/brand/gt-logo-*.svg.Also fixes the
<picture>tag logic so the light logo shows in light mode and dark logo is the default.Greptile Summary
This PR makes two small, low-risk changes to
README.md: it updates the logo image URLs from the root path (/gt-logo-*.svg) to the/brand/subdirectory (/brand/gt-logo-*.svg), and it inverts the<picture>element's theme-switching logic so the dark logo is the<img>fallback (shown by default and in dark mode) while the light logo is served explicitly only when the user's color scheme islight.Key changes:
/gt-logo-*.svg→/brand/gt-logo-*.svg<source>media query changed from(prefers-color-scheme: dark)→(prefers-color-scheme: light)<img>fallback changed from the light logo to the dark logo — meaning users with no color-scheme preference will now see the dark logo instead of the light oneMinor note: The PR description frames the logic change as a "fix", but the original code was not broken — both approaches are valid. The behavioral difference is only for users who have not set a color-scheme preference: previously they would see the light logo; now they will see the dark logo. This is a deliberate design decision and appears intentional.
Confidence Score: 5/5
README.mdis changed; no production code, logic, or configuration is affected. The URL and HTML changes are straightforward and low-risk.Important Files Changed
/brand/path and inverts<picture>element logic so the dark logo is the default fallback and the light logo is served only when light mode is detected.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Browser loads README] --> B{Supports prefers-color-scheme?} B -- No --> D[Render fallback img\ngt-logo-dark.svg] B -- Yes --> C{Color scheme preference?} C -- light --> E[Render source\ngt-logo-light.svg] C -- dark --> D C -- no preference --> DLast reviewed commit: "fix: update logo URL..."