Skip to content

fix: update logo URLs to /brand/ path#26

Merged
ErnestM1234 merged 2 commits intogeneraltranslation:mainfrom
moss-bryophyta:fix/update-logo-urls
Mar 20, 2026
Merged

fix: update logo URLs to /brand/ path#26
ErnestM1234 merged 2 commits intogeneraltranslation:mainfrom
moss-bryophyta:fix/update-logo-urls

Conversation

@moss-bryophyta
Copy link
Copy Markdown
Contributor

@moss-bryophyta moss-bryophyta commented Mar 18, 2026

Updates README logo URLs from generaltranslation.com/gt-logo-*.svg to generaltranslation.com/brand/gt-logo-*.svg.

Also fixes the <picture> tag logic so the light logo shows in light mode and dark logo is the default.

Greptile Summary

This PR makes two small, low-risk changes to README.md: it updates the logo image URLs from the root path (/gt-logo-*.svg) to the /brand/ subdirectory (/brand/gt-logo-*.svg), and it inverts the <picture> element's theme-switching logic so the dark logo is the <img> fallback (shown by default and in dark mode) while the light logo is served explicitly only when the user's color scheme is light.

Key changes:

  • Logo URL paths updated: /gt-logo-*.svg/brand/gt-logo-*.svg
  • <source> media query changed from (prefers-color-scheme: dark)(prefers-color-scheme: light)
  • <img> fallback changed from the light logo to the dark logo — meaning users with no color-scheme preference will now see the dark logo instead of the light one

Minor note: The PR description frames the logic change as a "fix", but the original code was not broken — both approaches are valid. The behavioral difference is only for users who have not set a color-scheme preference: previously they would see the light logo; now they will see the dark logo. This is a deliberate design decision and appears intentional.

Confidence Score: 5/5

  • This PR is safe to merge — it only modifies README.md with a URL path update and a deliberate inversion of the logo theme-selection fallback.
  • Only README.md is changed; no production code, logic, or configuration is affected. The URL and HTML changes are straightforward and low-risk.
  • No files require special attention.

Important Files Changed

Filename Overview
README.md Updates logo URLs to /brand/ path and inverts <picture> element logic so the dark logo is the default fallback and the light logo is served only when light mode is detected.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Browser loads README] --> B{Supports prefers-color-scheme?}
    B -- No --> D[Render fallback img\ngt-logo-dark.svg]
    B -- Yes --> C{Color scheme preference?}
    C -- light --> E[Render source\ngt-logo-light.svg]
    C -- dark --> D
    C -- no preference --> D
Loading

Last reviewed commit: "fix: update logo URL..."

@ErnestM1234 ErnestM1234 merged commit c972561 into generaltranslation:main Mar 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants