Skip to content

feat(js/plugins/google-genai): Support for gemini-embedding-2#5165

Merged
ifielker merged 2 commits into
mainfrom
if-embedding2
Apr 23, 2026
Merged

feat(js/plugins/google-genai): Support for gemini-embedding-2#5165
ifielker merged 2 commits into
mainfrom
if-embedding2

Conversation

@ifielker
Copy link
Copy Markdown
Collaborator

Checklist (if applicable):

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for the gemini-embedding-2 model, configuring it with 3072 dimensions and multimodal input capabilities. Additionally, a test flow was added to demonstrate multimodal embedding with custom output dimensionality. Feedback suggests updating the EmbeddingConfigSchema documentation to reflect the 3072-dimension default for this model, as the current description incorrectly specifies a 768-dimension default for all models.

Comment thread js/plugins/google-genai/src/googleai/embedder.ts
@ifielker ifielker requested a review from pavelgj April 22, 2026 21:21
@ifielker ifielker merged commit 43d719c into main Apr 23, 2026
8 checks passed
@ifielker ifielker deleted the if-embedding2 branch April 23, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants