Skip to content

sys-power/auto-cpufreq: add 3.0.0#452

Open
d3finit wants to merge 3 commits into
gentoo:devfrom
d3finit:dev
Open

sys-power/auto-cpufreq: add 3.0.0#452
d3finit wants to merge 3 commits into
gentoo:devfrom
d3finit:dev

Conversation

@d3finit

@d3finit d3finit commented Mar 24, 2026

Copy link
Copy Markdown

CC: @Schievel1 pinging you since you're the maintainer

fi

# Remove auto-cpufreq log file
if [ -f "${EROOT}/var/log/auto-cpufreq.log" ]; then

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would recommend changing the posix's [ to bash's [[, as per the coding style: https://projects.gentoo.org/qa/policy-guide/ebuild-format.html#pg0101

@ingenarel

Copy link
Copy Markdown
Contributor

please use git rebase and do a single commit, instead of the new chore: commit

changed POSIX's [ to bash's [[, per coding style https://projects.gentoo.org/qa/policy-guide/ebuild-format.html#pg0101
Signed-off-by: d3finit <68038925+d3finit@users.noreply.github.com>
@Schievel1

Copy link
Copy Markdown
Contributor

We don't do this proxy maintainer stuff with PRs in GURU.
If you have access to GURU you can just push it.

If not let me know and I will see how I can get your commit in.

@ingenarel

Copy link
Copy Markdown
Contributor

i mean they're not proxy maintaining or adding a new package, rather just doing a version bump, you can simply merge it with pram right?

i could be mistaken tho

@d3finit

d3finit commented Apr 14, 2026

Copy link
Copy Markdown
Author

I don't have write access to the GURU yet, thanks for trying to help get my commit in

@xz-dev xz-dev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the version bump. I checked this against the v3.0.0 sources and there are still two packaging fixes missing before it is complete:

  1. auto_cpufreq/core.py in 3.0.0 now also uses /opt/auto-cpufreq/turbo-override.pickle, but the ebuild only rewrites override.pickle. turbo-override.pickle should be moved to /var/lib/auto-cpufreq as well.

  2. auto_cpufreq/gui/objects.py still hardcodes /usr/local/share/auto-cpufreq/images/icon.png for the About dialog. The current sed rules only cover auto_cpufreq/gui/app.py, so the About dialog icon path would stay wrong under Gentoo.

  3. include python 3.14

auto-cpufreq-3.0.0.ebuild.txt

Could you please add those too?

@xz-dev

xz-dev commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

I opened a follow-up PR with the ebuild from my review comment so the original author can merge it directly: d3finit#1

@xz-dev

xz-dev commented May 5, 2026

Copy link
Copy Markdown
Contributor

Hi, any update at here?

sys-power/auto-cpufreq: fix 3.0.0 path rewrites
@d3finit

d3finit commented May 6, 2026

Copy link
Copy Markdown
Author

Hello, so sorry again for the delay, I just merged that into my repo, so I'm just waiting for a contributor to merge/request any more changes now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants