PB-2064: Fix import tool file #1516
Open
+325
−152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismailsunni
changed the title
ismailsunni
force-pushed
the
fix-pb-2026-fix-import-tool-file
branch
from
6d73615 to
72ddce0
Compare
and fix some TS error found in legacyParamImport.cy.ts
ismailsunni
force-pushed
the
fix-pb-2026-fix-import-tool-file
branch
4 times, most recently
from
0574a90 to
b0e473a
Compare
…s and simplify composable
- Add validation checks before store assertions for non-CORS GPX import - Handle menu re-renders after layer removal with stabilization waits - Add conditional warning window handling - Move profile intercept setup before interactions
…after reload on the KML layer
When importing a KML file that is outside the extent, the parser was showing "Invalid file" error instead of the correct "out of bounds" error. The issue occurred because parseAll() threw the first rejected error from any parser, which was typically InvalidFileContentError from parsers that couldn't handle the file format. However, the KML parser correctly identified the file as KML and threw a more specific OutOfBoundsError. Fixed by prioritizing specific errors (OutOfBounds, Empty, UnknownProjection) over generic InvalidFileContentError, ensuring users see the most relevant error message.
ismailsunni
force-pushed
the
fix-pb-2026-fix-import-tool-file
branch
from
b0e473a to
abde6f8
Compare
ismailsunni
changed the title
Copilot finished reviewing on behalf of
ismailsunni
December 1, 2025 04:09
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issues with the import tool file functionality, including improvements to layer ID handling, validation reactivity, error message prioritization, and test stability.
Key changes:
- Added
KML|andGPX|prefixes to layer IDs throughout the application for consistent layer identification - Refactored validation composable to use
ComputedRef<props>for better reactivity - Improved error prioritization in file parsers to show more specific errors (OutOfBounds, Empty, UnknownProjection) over generic errors
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/viewer/tests/cypress/tests-e2e/importToolFile.cy.ts | Updated test expectations to match new layer ID format with KML| and GPX| prefixes; improved test stability with proper wait conditions; refactored 3D test into separate skipped test; added profile intercept constant |
| packages/viewer/src/utils/composables/useFieldValidation.ts | Changed props parameter from object to ComputedRef for proper reactivity; updated to emit full ValidationResult object instead of boolean; removed unused toRef import |
| packages/viewer/src/utils/components/TextInput.vue | Converted validationProps to computed ref for consistency with updated composable |
| packages/viewer/src/utils/components/TextAreaInput.vue | Converted validationProps to computed ref for consistency with updated composable |
| packages/viewer/src/utils/components/FileInput.vue | Converted validationProps to computed ref; updated default prop values and parameter handling; added computedRequired usage |
| packages/viewer/src/utils/components/EmailInput.vue | Converted validationProps to computed ref for consistency with updated composable |
| packages/viewer/src/modules/menu/components/advancedTools/ImportFile/parser/index.ts | Implemented error prioritization logic to show specific errors (OutOfBounds, Empty, UnknownProjection) before generic InvalidFileContentError |
| packages/viewer/src/modules/menu/components/advancedTools/ImportFile/parser/KMLParser.class.ts | Added KML name parsing and proper layer initialization with name, hasWarning, and isLoading properties |
| packages/viewer/src/modules/menu/components/advancedTools/ImportFile/parser/GPXParser.class.ts | Added gpxFileUrl parameter to layer creation for proper GPX layer initialization |
| packages/viewer/src/modules/menu/components/advancedTools/ImportFile/ImportFileOnlineTab.vue | Fixed loading state handling by removing delayed timeout and setting state immediately; reordered props for clarity |
| packages/viewer/src/modules/menu/components/advancedTools/ImportFile/ImportFileLocalTab.vue | Added validMarker prop to FileInput for consistent validation feedback |
| packages/layers/src/utils/layerUtils.ts | Added automatic attribution generation based on file source (local files use filename, URLs use hostname); improved isLocalFile detection; added error handling for URL parsing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
| cy.reload() | ||
| cy.waitMapIsReady() | ||
|
|
||
| // TODO(IS): We shoudl check for warnings about missing local files, but it needs to be fixed first (related to url) |
There was a problem hiding this comment.
Typo in comment: "shoudl" should be "should"
Suggested change
| // TODO(IS): We shoudl check for warnings about missing local files, but it needs to be fixed first (related to url) | |
| // TODO(IS): We should check for warnings about missing local files, but it needs to be fixed first (related to url) |
sommerfe
force-pushed
the
feat-PB-1383-pinia-store
branch
2 times, most recently
from
a1cccff to
9e6d8d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes for fixing the tests:
Test link