Skip to content

#12774 Title and Name should be available in General Tab for all layer types that support it - #12787

Merged
offtherailz merged 5 commits into
geosolutions-it:masterfrom
Binabh:feat/add-name-in-toc
Aug 26, 2026
Merged

#12774 Title and Name should be available in General Tab for all layer types that support it#12787
offtherailz merged 5 commits into
geosolutions-it:masterfrom
Binabh:feat/add-name-in-toc

Conversation

@Binabh

@Binabh Binabh commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Description

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Feature

Issue

What is the current behavior?

#12774

What is the new behavior?
Name is editable for wfs,arcgis and arcgis-feature

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

@Binabh Binabh added this to the 2026.03.00 milestone Aug 11, 2026
@cla-bot cla-bot Bot added the CLA Ready label Aug 11, 2026
@Binabh
Binabh removed the request for review from stefanocudini August 11, 2026 08:08

@offtherailz offtherailz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here my review

  • notice that this may conflict or make test failing when merged with #12802 (e.g. tests counting elements in properties window, or real conflicts). I'd suggest to take care of this first, that is smaller, and then update #12802 resolving conflicts.
  • as well as for #12802, when changing the layer name, maybe the fields should be refreshed, in the same way
  • In the case of the ImageLayer crashes. Please checi if in this case the layer name editing makes sense.
Screencast.from.2026-08-18.18-22-34.webm

Here the map to reproduce the issue

map (1).json
map.json

@offtherailz offtherailz assigned Binabh and unassigned offtherailz Aug 19, 2026
@tdipisa tdipisa assigned offtherailz and unassigned Binabh Aug 20, 2026
@Binabh

Binabh commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

@offtherailz Thank You For your review.

I have fixed the crashing and verified it. Yes name changing did not made sense in such Arcgis layers where name is absent, null or empty.
Also, I have tried to make tests more robust so that it would work better in case of #12802 also. Let me know your view on that. But we may need to manually fix conflicts(specially in case of tests) after one of them is merged.

Please let me know if any further improvement need to be made.
Thank You!

@Binabh
Binabh requested a review from offtherailz August 21, 2026 16:43
@offtherailz
offtherailz merged commit 0f6fdac into geosolutions-it:master Aug 26, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Title and Name should be available in General Tab for all layer types that support it

4 participants