release-artifacts: require the uploaded asset, not just the pinned url - #93
Merged
Conversation
The idempotency guard skipped build+pin+upload whenever Package.swift's fallback url already named the tag — but a url pinned by hand (or by a run that failed mid-upload) with no asset then leaves the tag resolving to a 404. Also require the xcframework.zip asset to actually exist on the release before treating the tag as finalized. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two release-robustness fixes prompted by v0.10.0 shipping with no xcframework asset (its binaryTarget url 404'd):
Package.swift's fallback url already named the tag. A url pinned by hand (or by a run that failed mid-upload) with no uploaded asset then leaves the tag resolving to a 404. Now also require thexcframework.zipasset to actually exist before treating the tag as finalized.Package.swiftthat the binaryTarget url+checksum must always name an already-released tag with its real CI checksum (never pre-bump to an unreleased version — that's what defeats the guard). Also correct main's checksum from the local placeholder to the released CI value (897071cf…).v0.10.0 itself was already recovered by re-dispatching this workflow after fix (1).
🤖 Generated with Claude Code