Skip to content

Keep timeline lightbox selection stable as images change - #3596

Merged
brsbl merged 15 commits into
fix/timeline-image-navigationfrom
fix/lightbox-live-selection
Sep 12, 2026
Merged

Keep timeline lightbox selection stable as images change#3596
brsbl merged 15 commits into
fix/timeline-image-navigationfrom
fix/lightbox-live-selection

Conversation

@brsbl

@brsbl brsbl commented Sep 12, 2026

Copy link
Copy Markdown
Collaborator

Human comments

What was wrong

The gallery kept a stale image list and used rendered order to identify repeated images. Timeline updates could lose selection, expose clipped images, or leave navigation unavailable. Navigation wrapped at the ends, and disabled arrow taps dismissed the overlay.

What changed

  • Refresh navigation from the loaded, expanded timeline while retaining only the currently displayed image when it becomes ineligible.
  • Preserve image occurrence identity through streaming and Markdown normalization using source positions.
  • Stop at each end and absorb disabled-arrow taps without dismissing the lightbox.

How you verified

  • Remote CI passed at ab809c73d7c0292d94a36c1d44bedb86271a6bfc, including ten gallery regression cases.
  • Duplicate inline/footnote regressions failed before the fix and passed afterward, including normalized source offsets and cached streaming blocks.
  • Chrome for Testing 153.0.8010.36 confirmed endpoint touch, mouse, and keyboard behavior at 0bd3f0ce1.

Final-candidate browser verification and refreshed screenshots remain unverified: the isolated dev-app route timed out twice. The user requested merging after this gap was reported. Earlier retention, expansion/collapse, and endpoint evidence does not establish final-candidate live streaming behavior.

Historical before and after

Same synthetic timeline, last image, disabled Next tap, and 390 × 844 CSS viewport at 2×. Before: a20b3748c. After: 0bd3f0ce1. These captures predate main integration and are not an exact parent/head comparison for this layer.

Before: tapping disabled Next dismisses After: tapping disabled Next keeps image 7 / 7 open
Before disabled Next tap After disabled Next tap

BB-Thread-ID: thr_rmv43jkeac

AGENT GENERATED

@brsbl
brsbl added this pull request to stack #3490 September 12, 2026 22:05
@brsbl
brsbl merged commit f3e43c4 into main Sep 12, 2026
38 of 39 checks passed
@brsbl
brsbl deleted the fix/lightbox-live-selection branch September 12, 2026 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant