Skip to content

fix: remove redundant ROKU_DEV_USER #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bchelkowski merged 1 commit into from
Mar 24, 2026
Merged

fix: remove redundant ROKU_DEV_USER #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ kopytko --help
kopytko <command> --help
```


| Command | Alias | Description |
|:----------:|:-----:|----------------------------------------------------------|
| screenshot | sc | Takes a screenshot of current application |
Expand Down
2 changes: 0 additions & 2 deletions commands/package.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
const rokuDevSigningPasswordOption = require('../options/rokuDevSigningPassword');
const signedPackagePathOption = require('../options/signedPackagePath');
const rokuDevPasswordOption = require('../options/rokuDevPassword');
const rokuDevUserOption = require('../options/rokuDevUser');
const forceHttpOption = require('../options/forceHttp');
const rokuDevIdOption = require('../options/rokuDevId');
const rokuIPOption = require('../options/rokuIP');
Expand All @@ -16,7 +15,6 @@ function load(program) {
.addOption(envOption)
.addOption(rokuIPOption)
.addOption(rokuDevIdOption)
.addOption(rokuDevUserOption)
.addOption(rokuDevPasswordOption)
.addOption(rokuDevSigningPasswordOption)
.addOption(signedPackagePathOption)
Expand Down
2 changes: 0 additions & 2 deletions commands/screenshot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
const rokuDevPasswordOption = require('../options/rokuDevPassword');
const rokuDevUserOption = require('../options/rokuDevUser');
const rokuIPOption = require('../options/rokuIP');

function load(program) {
Expand All @@ -8,7 +7,6 @@ function load(program) {
.alias('sc')
.description('Takes a screenshot of the dev application')
.addOption(rokuIPOption)
.addOption(rokuDevUserOption)
.addOption(rokuDevPasswordOption)
.action(() => {
try {
Expand Down
2 changes: 0 additions & 2 deletions commands/start.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
const rokuDevPasswordOption = require('../options/rokuDevPassword');
const rokuDevUserOption = require('../options/rokuDevUser');
const forceHttpOption = require('../options/forceHttp');
const rokuIPOption = require('../options/rokuIP');
const telnetOption = require('../options/telnet');
Expand All @@ -12,7 +11,6 @@ function load(program) {
.description('Compiles and runs an application on a Roku device')
.addOption(envOption)
.addOption(rokuIPOption)
.addOption(rokuDevUserOption)
.addOption(rokuDevPasswordOption)
.addOption(forceHttpOption)
.addOption(telnetOption)
Expand Down
2 changes: 0 additions & 2 deletions commands/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
const rokuDevPasswordOption = require('../options/rokuDevPassword');
const testFileNameOption = require('../options/testFileName');
const rokuDevUserOption = require('../options/rokuDevUser');
const forceConnectOption = require('../options/forceConnect');
const forceHttpOption = require('../options/forceHttp');
const rokuIPOption = require('../options/rokuIP');
Expand All @@ -12,7 +11,6 @@ function load(program) {
.alias('t')
.description('Compiles and runs unit tests on a Roku device')
.addOption(rokuIPOption)
.addOption(rokuDevUserOption)
.addOption(rokuDevPasswordOption)
.addOption(testFileNameOption)
.addOption(telnetOption)
Expand Down
5 changes: 0 additions & 5 deletions options/rokuDevUser.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion schematics/lib/new/files/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ You can change predefined configuration inside `.env` file:

```
ROKU_IP=
ROKU_DEV_USER=
ROKU_DEV_PASSWORD=

ROKU_DEV_ID=
Expand Down
1 change: 0 additions & 1 deletion schematics/lib/new/new.factory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ function createEnvFile(options, path) {
return (tree) => {
tree.create(path + '/.env', `
ROKU_IP=${options.rokuIP}
ROKU_DEV_USER=${options.rokuDevUser}
ROKU_DEV_PASSWORD=${options.rokuDevPassword}

ROKU_DEV_ID=${options.rokuDevId}
Expand Down
5 changes: 0 additions & 5 deletions schematics/lib/new/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,6 @@
"default": "",
"x-prompt": "What is your Roku device IP address?"
},
"rokuDevUser": {
"type": "string",
"default": "rokudev",
"x-prompt": "What is your Roku device dev user?"
},
"rokuDevPassword": {
"type": "string",
"default": "",
Expand Down