Skip to content

Conversation

@honzap
Copy link
Contributor

@honzap honzap commented Dec 11, 2024

Please read CONTRIBUTING.md for additional information on contributing to this repository!

What this PR does / why we need it

related to #561 - it this one is approved, just please close the other one.

This is introducing ability to specify the command should have asset, otherwise, it's not built.

Only CLI tools like clerkcli, devenv, orc need it, so it'll be added there. The rest of the services don't need to build the binaries and assets. This saves build time on CircleCI and also storage of Assets in GitHub.

Discussed in Slack

Opened half an year later again.

One example:

apiproxy service has couple of CLI commands but there's no need to have a build of them locally. It's possible to run them via go run locally and in the pod, it's provided by Dockerfile.

Every release contains 4 tar.gz files with the tools binary which is never used.

% tar tfz /tmp/download/apiproxy_1.225.8_darwin_amd64.tar.gz                                                                                                                               
README.md
tools

Jira ID

[XX-XX]

Notes for your reviewers

@honzap honzap requested a review from a team as a code owner December 11, 2024 15:31
@honzap honzap force-pushed the honzap/feat/goreleasercmd branch from 12c15fe to 8a4ea86 Compare December 12, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant