fix(server): capture Codex skill warnings during agent creation#523
Open
edvardchen wants to merge 1 commit into
Open
fix(server): capture Codex skill warnings during agent creation#523edvardchen wants to merge 1 commit into
edvardchen wants to merge 1 commit into
Conversation
7ec394c to
5c90449
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skills/listvalidation failures as timeline errors instead of silently dropping themcreateAgentso startup warnings are recorded for newly created Codex agentsBug
When Codex returns startup warnings from
skills/listsuch as invalidSKILL.mdfiles, Paseo only exposed them through provider history. Resume and refresh flows hydrated that history, but the create-agent flow did not. As a result, a newly created Codex agent could start with a warning likeSkipped loading 1 skill due to invalid SKILL.md file, yet the daemon timeline stayed empty and the desktop app showed nothing.Repro
.codex/skills/*/SKILL.md.Fix
The provider now turns
skills/list.errors[]into timelineerroritems, and the create-agent path now callshydrateTimelineFromProvider(snapshot.id)before forwarding the new agent snapshot. That makes the startup warning durable and visible to desktop on first creation, not only after resume/refresh.Testing
./node_modules/.bin/vitest run packages/server/src/server/session.test.ts packages/server/src/server/agent/providers/codex-app-server-agent.test.ts --bail=1