feat(app): add find in pane across panes#675
Open
boudra wants to merge 5 commits into
Open
Conversation
- A bridge: remove renderer webview find fallback and require the Electron bridge path - B core: tighten pane-find assertions and hide internal search/render types - C adapters: align chat/file search registration with highlightable content - D harness: delete flaky Electron QA harness and simplify keyboard dispatcher scope
Collaborator
Author
|
Applied the four-way find-in-pane cleanup pass in 9e478a0.
Delta: 19 files changed, 221 insertions(+), 1924 deletions(-). |
The terminal find pane matches the echoed printf command line in addition to the printed output, so the actual count is 4 / 4. Match any non-zero count, mirroring the chat assertion below it — this step only verifies that find found something before clicking away.
3 tasks
7ec394c to
5c90449
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Manual test plan
QA note
Automated Playwright Electron QA was attempted, but it produced inconsistent results because CDP/keyboard interactions did not reliably exercise Electron's find subsystem or deliver
found-in-pageevents in the harness. The Electron bridge is verified by inspection plus bridge/unit tests; a real Electron manual smoke pass is still needed.