[codex] add workspace file previews and robust web downloads#736
Open
rowankid wants to merge 3 commits intogetpaseo:mainfrom
Open
[codex] add workspace file previews and robust web downloads#736rowankid wants to merge 3 commits intogetpaseo:mainfrom
rowankid wants to merge 3 commits intogetpaseo:mainfrom
Conversation
7487e25 to
dbce3a4
Compare
dbce3a4 to
98be934
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds workspace file previews and fixes web downloads for remote browser sessions.
.drawioand.drawio.xmlfiles..docxand spreadsheet files using third-party viewers/parsers.Root Cause
Cross-machine browser sessions cannot assume a direct local daemon download host. The previous web download path required a direct HTTP target, while previews and fallback downloads use
readFileover the active WebSocket. Larger docx/xlsx/drawio files could also exceed the generic 10s correlated request timeout.Validation
npx vitest run packages/app/src/stores/download-store.test.ts --bail=1npx vitest run packages/server/src/client/daemon-client.test.ts packages/app/src/stores/download-store.test.ts --bail=1npm run format && npm run format:checknpm run typechecknpm run lintnpm run build:web --workspace=@getpaseo/appDeployment
Cloudflare Pages production has been updated and verified to serve bundle
_expo/static/js/web/index-039df1bc75b0910f36fae94c96de6032.js.