Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
For Atom entries without pubdate or updateddate, add_item_elements currently uses naive datetime.now(). rfc3339_date appends Z to naive values. On a UTC+8 machine at 20:34:56 local time, an undated entry therefore reports 20:34:56Z instead of the actual instant 12:34:56Z. The feed-level updated fallback already correctly uses an aware UTC clock.
Minimal fix
Use datetime.datetime.now(tz=datetime.timezone.utc) for the undated entry fallback, matching latest_post_date. Explicit publication/update dates and the public date-formatting function remain unchanged.
Validation
Checked latest main, existing issues/PRs and repository guidance. AI-assisted investigation, implementation and synthetic test design; stated validation executed locally. No private data or unrelated refactoring.