feat(attributes): Add browser.bfcache.* attributes#513
Draft
logaretm wants to merge 2 commits into
Draft
Conversation
Registers the four attributes emitted by the new bfcacheMetricsIntegration in the JS SDK: browser.bfcache.outcome, browser.bfcache.reason, browser.bfcache.frame, and browser.bfcache.not_restored_reason_count. All are Sentry-specific (not in OTel).
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Other
Internal Changes 🔧Attributes
Other
🤖 This preview updates automatically when you update the PR. |
The SDK frames reasons purely by position; 'masked' is a reason value, not a frame, so drop it (and 'unknown') from the frame attribute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registers the four
browser.bfcache.*attributes emitted by the newbfcacheMetricsIntegrationin the JS SDK (getsentry/sentry-javascript#22397).They describe browser back/forward-cache health metrics.
browser.bfcache.outcome—hit/missof a back/forward navigation.browser.bfcache.reason— a browser-reported not-restored reason (one per reason; a single miss can have several; Chromium-only vianotRestoredReasons).browser.bfcache.frame— which frame the reason came from (top/child/masked/unknown).browser.bfcache.not_restored_reason_count— number of reported reasons (0when the browser reported none, e.g. non-Chromium).All are Sentry-specific, so
is_in_otel: falseand PII is not applicable here.