Skip to content

ref(server-utils): Small fastify cleanup #22385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mydea merged 2 commits into from
Jul 20, 2026
+3 −6
Merged

ref(server-utils): Small fastify cleanup #22385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ad7a3e
ref: Small fastify cleanup
mydea Jul 20, 2026
6fdb8a9
fix
mydea Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions packages/server-utils/src/integrations/tracing-channel/fastify/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import type { IntegrationFn } from '@sentry/core';
import { defineIntegration } from '@sentry/core';
import type { FastifyIntegration, FastifyReply, FastifyRequest } from './types';

import { instrumentFastify as _instrumentFastify } from './instrumentation';
import { defaultShouldHandleError, INTEGRATION_NAME } from './utils';
import { subscribeToFastifyErrorChannel, handleFastifyError as _handleFastifyError } from './errors';
Expand Down Expand Up @@ -41,7 +40,7 @@ interface FastifyIntegrationOptions {
shouldHandleError: (error: Error, request: FastifyRequest, reply: FastifyReply) => boolean;
}

const _fastifyIntegration = (({ shouldHandleError }: Partial<FastifyIntegrationOptions>) => {
const _fastifyIntegration = (({ shouldHandleError }: Partial<FastifyIntegrationOptions> = {}) => {
let _shouldHandleError: (error: Error, request: FastifyRequest, reply: FastifyReply) => boolean;

return {
Expand Down Expand Up @@ -76,9 +75,7 @@ const _fastifyIntegration = (({ shouldHandleError }: Partial<FastifyIntegrationO
* })
* ```
*/
export const fastifyIntegration = defineIntegration((options: Partial<FastifyIntegrationOptions> = {}) =>
_fastifyIntegration(options),
);
export const fastifyIntegration = defineIntegration(_fastifyIntegration);
Comment thread
cursor[bot] marked this conversation as resolved.

/**
* @deprecated This export is deprecated and will not longer be exposed in the next major version.
Expand Down
2 changes: 1 addition & 1 deletion packages/server-utils/src/integrations/tracing-channel/fastify/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { FastifyReply, FastifyRequest } from './types';

export const INTEGRATION_NAME = 'Fastify';
export const INTEGRATION_NAME = 'Fastify' as const;

/**
* Default function to determine if an error should be sent to Sentry
Expand Down
Loading