feat(browser): Classify bfcache not-restored reasons by category and actionability#22398
Closed
logaretm wants to merge 1 commit into
Closed
feat(browser): Classify bfcache not-restored reasons by category and actionability#22398logaretm wants to merge 1 commit into
logaretm wants to merge 1 commit into
Conversation
Contributor
size-limit report 📦
|
Member
Author
|
Closing because I think the info here can drift, so the SDK should not collect these but could be inferred on the product. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
browser.bfcache.reason_category(page_lifecycle / network / storage / realtime / embed / browser / unknown) and abrowser.bfcache.actionableboolean to eachbrowser.bfcache.not_restoredmetric, from a small SDK-side mapping of the known reason strings.The raw
notRestoredReasonsstrings are useful but opaque and, as Chrome explicitly warns, subject to change. Bucketing them into durable categories plus a "can the developer fix this?" flag makes a miss answer both "why" and "what to do" on a dashboard, without pinning the dashboard to volatile strings. Unrecognized reasons degrade tounknown/ non-actionable, so a new browser reason never silently breaks grouping.The mapping is unit-tested, and the e2e app asserts the category/actionable pair end-to-end against the real reasons it can reproduce: unload → page_lifecycle, WebSocket → realtime, IndexedDB versionchange → storage, no-store → network, and the privacy-masked reason → embed / non-actionable.
Builds on #22397.