ref(node): Merge @sentry/node-core back into @sentry/node#22418
Draft
andreiborza wants to merge 6 commits into
Draft
ref(node): Merge @sentry/node-core back into @sentry/node#22418andreiborza wants to merge 6 commits into
@sentry/node-core back into @sentry/node#22418andreiborza wants to merge 6 commits into
Conversation
Remove the `@sentry/node-core` package and fold its functionality back into `@sentry/node`. Light mode and the OTel peer-dependency model are dropped; `@sentry/node` keeps the OTel dependencies it actually uses. - Move node-core source into `packages/node/src`; the composite HTTP/fetch integrations become the canonical implementations. - Migrate consumers (effect, aws-serverless, bun, google-cloud-serverless, nuxt) off `@sentry/node-core`. - Merge node-core's unique unit and integration tests into node and node-integration-tests; drop the redundant node-core test packages and e2e apps. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Member
Author
|
batman begin |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 6986207. Configure here.
Contributor
size-limit report 📦
|
…me effect transaction e2e
…-into-node # Conflicts: # dev-packages/node-core-integration-tests/package.json # packages/nuxt/package.json
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1405e18. Configure here.
…ion; keep node default integrations disabled in effect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
@sentry/node-corepackage and folds its functionality back into@sentry/node.@sentry/node; the composite HTTP and node-fetch integrations become the canonical implementations.@sentry/nodekeeps only the OpenTelemetry dependencies it actually uses (@opentelemetry/corepromoted to a direct dependency;exporter-trace-otlp-httpdropped).effect,aws-serverless,bun,google-cloud-serverless,nuxt) off@sentry/node-core.@sentry/nodeandnode-integration-tests; discards the redundant ones. Removes thenode-core-integration-testspackage and the node-core e2e apps.@sentry/node-corefrom workspaces,.craft.yml,.size-limit.js, CODEOWNERS, and CI.The public API surface of
@sentry/nodeis unchanged.@sentry/effect@sentry/effectserver now runs on full@sentry/node(previously@sentry/node-core/light) and disables node's default integrations, since it provides its own tracing, logging and error capture. Its server transaction e2e tests are markedtest.fixme: light mode set an AsyncLocalStorage async context strategy that matched Effect's fiber model, whereas full node installs the OpenTelemetry context strategy, so the Effect tracer's spans are no longer emitted as transactions. Adapting Effect's server tracing to the full-node context model is follow-up work.Why
@sentry/node-corewas split out to offer the Node client without bundled OpenTelemetry instrumentation and with widened OTel peer ranges. The story around node without OpenTelemetry will change in v11 and we will no longer need this distinctive SDKs. The so-called light mode will be achievable with our regular node SDK in follow up PRs.