Skip to content

fix(v10/core): Avoid propagating baggage: "undefined" when DSC is missing#22440

Merged
Lms24 merged 1 commit into
v10from
lms/fix-v10-core-undefined-header
Jul 21, 2026
Merged

fix(v10/core): Avoid propagating baggage: "undefined" when DSC is missing#22440
Lms24 merged 1 commit into
v10from
lms/fix-v10-core-undefined-header

Conversation

@Lms24

@Lms24 Lms24 commented Jul 21, 2026

Copy link
Copy Markdown
Member

Backport of #22424

…ng (#22424)

Fix a bug where us adding a header with value `undefined` to fetch request would cause the header to be sent with the string-coersed `"undefined"` instead of dropping the header. This patch now only adds the header if it's defined instead.
@Lms24
Lms24 requested a review from a team as a code owner July 21, 2026 14:55
@Lms24
Lms24 requested review from logaretm and msonnb and removed request for a team July 21, 2026 14:55
@Lms24 Lms24 self-assigned this Jul 21, 2026
@Lms24 Lms24 changed the title fix(core): Avoid propagating baggage: "undefined" when DSC is missing fix(v10/core): Avoid propagating baggage: "undefined" when DSC is missing Jul 21, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e677c17. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 27.75 kB added added
@sentry/browser - with treeshaking flags 26.18 kB added added
@sentry/browser (incl. Tracing) 46.58 kB added added
@sentry/browser (incl. Tracing + Span Streaming) 48.39 kB added added
@sentry/browser (incl. Tracing, Profiling) 51.38 kB added added
@sentry/browser (incl. Tracing, Replay) 85.85 kB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 75.48 kB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 90.57 kB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 103.22 kB added added
@sentry/browser (incl. Feedback) 44.93 kB added added
@sentry/browser (incl. sendFeedback) 32.55 kB added added
@sentry/browser (incl. FeedbackAsync) 37.69 kB added added
@sentry/browser (incl. Metrics) 28.83 kB added added
@sentry/browser (incl. Logs) 29.05 kB added added
@sentry/browser (incl. Metrics & Logs) 29.76 kB added added
@sentry/react 29.54 kB added added
@sentry/react (incl. Tracing) 48.86 kB added added
@sentry/vue 33.17 kB added added
@sentry/vue (incl. Tracing) 48.54 kB added added
@sentry/svelte 27.78 kB added added
CDN Bundle 30.14 kB added added
CDN Bundle (incl. Tracing) 48.55 kB added added
CDN Bundle (incl. Logs, Metrics) 31.73 kB added added
CDN Bundle (incl. Tracing, Logs, Metrics) 49.85 kB added added
CDN Bundle (incl. Replay, Logs, Metrics) 70.99 kB added added
CDN Bundle (incl. Tracing, Replay) 86.06 kB added added
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 87.37 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 91.86 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 93.14 kB added added
CDN Bundle - uncompressed 89.88 kB added added
CDN Bundle (incl. Tracing) - uncompressed 146.78 kB added added
CDN Bundle (incl. Logs, Metrics) - uncompressed 94.59 kB added added
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 150.76 kB added added
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 219.35 kB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 266.02 kB added added
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 269.98 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 279.72 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 283.67 kB added added
@sentry/nextjs (client) 51.37 kB added added
@sentry/sveltekit (client) 47.01 kB added added
@sentry/core/server 80.27 kB added added
@sentry/core/browser 66.71 kB added added
@sentry/node-core 63.21 kB added added
@sentry/node 125.76 kB added added
@sentry/node (incl. diagnostics channel injection) 151.2 kB added added
@sentry/node/import (ESM hook with diagnostics-channel injection) 70.03 kB added added
@sentry/node/light 51.32 kB added added
@sentry/node - without tracing 74.92 kB added added
@sentry/aws-serverless 84.15 kB added added
@sentry/cloudflare (withSentry) - minified 197.71 kB added added
@sentry/cloudflare (withSentry) 486.7 kB added added

@Lms24
Lms24 merged commit f5ee1e4 into v10 Jul 21, 2026
307 of 308 checks passed
@Lms24
Lms24 deleted the lms/fix-v10-core-undefined-header branch July 21, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants