Skip to content

Conversation

@alexander-alderman-webb
Copy link
Contributor

@alexander-alderman-webb alexander-alderman-webb commented Nov 6, 2025

Description

Set the default value for max_data_size option of RedisIntegration to None, so that Redis span descriptions are not truncated by default.

Deprecate the option as well, announcing its removal in the next major.

Issues

Closes #4990
Closes PY-1918

Reminders

@linear
Copy link

linear bot commented Nov 6, 2025

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.97%. Comparing base (faa327c) to head (233eef3).
⚠️ Report is 20 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/integrations/redis/modules/caches.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5073      +/-   ##
==========================================
+ Coverage   83.96%   83.97%   +0.01%     
==========================================
  Files         179      179              
  Lines       17943    17949       +6     
  Branches     3192     3194       +2     
==========================================
+ Hits        15066    15073       +7     
  Misses       1905     1905              
+ Partials      972      971       -1     
Files with missing lines Coverage Δ
sentry_sdk/integrations/redis/__init__.py 93.10% <100.00%> (+0.79%) ⬆️
sentry_sdk/integrations/redis/consts.py 100.00% <100.00%> (ø)
sentry_sdk/integrations/redis/modules/queries.py 93.54% <100.00%> (-0.21%) ⬇️
sentry_sdk/integrations/redis/modules/caches.py 88.13% <0.00%> (-0.20%) ⬇️

... and 3 files with indirect coverage changes

@alexander-alderman-webb alexander-alderman-webb marked this pull request as ready for review November 6, 2025 10:03
@alexander-alderman-webb alexander-alderman-webb requested a review from a team as a code owner November 6, 2025 10:03
@alexander-alderman-webb alexander-alderman-webb merged commit c4071b3 into master Nov 18, 2025
129 of 130 checks passed
@alexander-alderman-webb alexander-alderman-webb deleted the webb/deprecate-redis-max-data-size branch November 18, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove span description truncation in Redis

3 participants