Fix console tracing

[Big-Shark]

I noticed that our project lacks spans when executing console commands. I found that upon completion of a console command, only one specific span is finalized, rather than the entire transaction, unlike the behavior in TracingRequestListener. After locally modifying it to complete the transaction and running console sentry:test, I observed the other spans that were previously missing. Therefore, I believe this fix should resolve the issue.

[Big-Shark]

The tests failed because they check for the invocation of the getSpan method.

I would like to understand whether there is a bug here and the tests need to be fixed, or if the issue lies elsewhere.

[Big-Shark]

@cleptric Hi, can you check my MR?

[Litarnus]

Hi @Big-Shark! Can you provide more information what you received before your change and after your change. It seems to make no difference for me when running sentry:test

[Big-Shark]

Hi

Before my changes, running sentry:test produced this output:

After my changes, it looks like this:

When I add a custom span in SentryTestCommand:

        $spanContext = \Sentry\Tracing\SpanContext::make()
            ->setOp('some_operation')
            ->setDescription('This is a description');
        \Sentry\trace(function () {
            sleep (3);
        }, $spanContext)

The output becomes:

Without these changes, the output is similar to the first screenshot.

[Big-Shark]

My sentry yaml config

when@prod: &sentry-prod
    parameters:
        sentry.traces_sample_rate: 0.1

    sentry:
        dsn: "%env(SENTRY_DSN)%"
        options:
            environment: "%env(DEPLOYMENT_ENV)%"
            release: '%env(APP_VERSION)%'
            send_default_pii: true
            traces_sample_rate: '%sentry.traces_sample_rate%'
            ignore_exceptions:
                - Symfony\Component\HttpKernel\Exception\NotFoundHttpException
                - Symfony\Component\Messenger\Exception\RejectRedeliveredMessageException
        register_error_listener: false # Disables the ErrorListener to avoid duplicated log in sentry

when@staging:
    <<: *sentry-prod
    parameters:
        sentry.traces_sample_rate: 0.3

when@dev:
    <<: *sentry-prod
    parameters:
        sentry.traces_sample_rate: 1

[Litarnus]

Thank you for your reply and sorry for coming back so late to you. I added your custom span to the SentryTestCommand and I got your expected results without your change (minus the event_dispatcher.dispatch). I tested it on the current master branch.

Could you provide a minimal working example where you reproduce the behaviour?

I'm generally a bit reluctant to finish transaction on console termination as this would also finish the transaction once a subcommand terminates.

[Big-Shark]

I couldn't reproduce this issue locally on a new project, though last time I did experiment on a clean project.
I'll close the issue and dive into debugging our app; the problem might be there.
Thanks for the help.