Skip to content

Conversation

@ameliahsu
Copy link
Member

redirects issue alert specific routes to the appropriate automation pages

@ameliahsu ameliahsu requested a review from a team as a code owner November 13, 2025 19:11
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 13, 2025
@codecov
Copy link

codecov bot commented Nov 13, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
14220 2 14218 45
View the top 2 failed test(s) by shortest run time
tests.acceptance.test_organization_alert_rule_details.OrganizationAlertRuleDetailsTest::test_alert_rule_with_issues
Stack Traces | 152s run time
#x1B[1m#x1B[31mtests/acceptance/test_organization_alert_rule_details.py#x1B[0m:36: in test_alert_rule_with_issues
    self.browser.wait_until_not('[data-test-id="loading-indicator"]')
#x1B[1m#x1B[.../testutils/pytest/selenium.py#x1B[0m:250: in wait_until_not
    wait.until_not(
#x1B[1m#x1B[31m.venv/lib/python3.13.../webdriver/support/wait.py#x1B[0m:128: in until_not
    raise TimeoutException(message)
#x1B[1m#x1B[31mE   selenium.common.exceptions.TimeoutException: Message:#x1B[0m
tests.acceptance.test_organization_alert_rule_details.OrganizationAlertRuleDetailsTest::test_empty_alert_rule_details
Stack Traces | 154s run time
#x1B[1m#x1B[31mtests/acceptance/test_organization_alert_rule_details.py#x1B[0m:24: in test_empty_alert_rule_details
    self.browser.wait_until_not('[data-test-id="loading-indicator"]')
#x1B[1m#x1B[.../testutils/pytest/selenium.py#x1B[0m:250: in wait_until_not
    wait.until_not(
#x1B[1m#x1B[31m.venv/lib/python3.13.../webdriver/support/wait.py#x1B[0m:128: in until_not
    raise TimeoutException(message)
#x1B[1m#x1B[31mE   selenium.common.exceptions.TimeoutException: Message:#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

}
}

return children;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: New UI Fails, Old Interface Returns

When the workflow-engine-ui feature flag is enabled and the API request completes without data (due to failure or missing workflow mapping), the component falls through to render the original alert rules UI. This creates inconsistent behavior where users with the feature flag enabled may still see the old UI when the API fails, rather than being handled explicitly with an error state or alternative redirect.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants