ref(crons): Add migration to backfill MonitorEnvironment.is_muted #103324
+159
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
src/sentry/monitors/migrations/0011_backfill_monitor_environment_is_muted.py
Outdated
Show resolved
Hide resolved
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
src/sentry/monitors/migrations/0011_backfill_monitor_environment_is_muted.py
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #103324 +/- ##
===========================================
+ Coverage 79.87% 80.57% +0.69%
===========================================
Files 9237 9242 +5
Lines 394575 394768 +193
Branches 25146 25146
===========================================
+ Hits 315184 318087 +2903
+ Misses 78944 76234 -2710
Partials 447 447 |
Contributor
|
This PR has a migration; here is the generated SQL for for --
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL |
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-crons-add-migration-to-backfill-monitorenvironment-is-muted
branch
from
dfd68e6 to
44fa9fa
Compare
wedamija
reviewed
Nov 13, 2025
Comment on lines
29
to
36
| muted_monitors = list( | ||
| Monitor.objects.filter( | ||
| id__gt=last_id, | ||
| is_muted=True, | ||
| ).order_by( | ||
| "id" | ||
| )[:batch_size] | ||
| ) |
Member
There was a problem hiding this comment.
You may as well just use RangeQuerySetWrapper and filter is_muted in memory. There's no index on id, is_muted so writing this manually won't help at all.
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-crons-add-migration-to-backfill-monitorenvironment-is-muted
branch
from
44fa9fa to
88a0a41
Compare
wedamija
approved these changes
Nov 13, 2025
Comment on lines
29
to
31
| muted_monitors = Monitor.objects.filter(is_muted=True) | ||
|
|
||
| for monitor in RangeQuerySetWrapperWithProgressBar(muted_monitors): |
Member
There was a problem hiding this comment.
You're better off filtering is_muted in memory here instead of the query, otherwise you might end up with timeouts.
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-crons-add-migration-to-backfill-monitorenvironment-is-muted
branch
from
88a0a41 to
9524607
Compare
src/sentry/monitors/migrations/0011_backfill_monitor_environment_is_muted.py
Show resolved
Hide resolved
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-crons-add-migration-to-backfill-monitorenvironment-is-muted
branch
from
9524607 to
196a9e9
Compare
![semgrep-code-getsentry[bot]](https://avatars.githubusercontent.com/in/1153895?s=60&v=4){kind=small}
src/sentry/monitors/migrations/0011_backfill_monitor_environment_is_muted.py
Show resolved
Hide resolved
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-crons-add-migration-to-backfill-monitorenvironment-is-muted
branch
from
196a9e9 to
2cc96dd
Compare
Implements Step 2 of the migration plan from [NEW-564: There needs to be some way to mute the entire cron detector](https://linear.app/getsentry/issue/NEW-564/there-needs-to-be-some-way-to-mute-the-entire-cron-detector) This data migration backfills MonitorEnvironment.is_muted from Monitor.is_muted for all muted monitors. This ensures existing data is consistent before switching to read from MonitorEnvironment.is_muted. After this migration runs: - Monitors with is_muted=True will have ALL environments muted - Monitors with is_muted=False will have environments unchanged This establishes the correct invariant: - Monitor is muted ↔ ALL environments are muted - Monitor is unmuted ↔ ANY environment is unmuted The migration: - Uses range queries for efficient batching (1000 monitors per batch) - Only updates environments for muted monitors (unmuted is the default) - Is marked as post-deployment for manual execution in production Test verifies: - Muted monitor environments are updated to is_muted=True - Unmuted monitor environments remain unchanged - Monitors without environments are unaffected
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-crons-add-migration-to-backfill-monitorenvironment-is-muted
branch
from
2cc96dd to
af3ae18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Step 2 of the migration plan from NEW-564: There needs to be some way to mute the entire cron detector
This data migration backfills MonitorEnvironment.is_muted from Monitor.is_muted for all muted monitors. This ensures existing data is consistent before switching to read from MonitorEnvironment.is_muted.
After this migration runs:
This establishes the correct invariant:
The migration:
Test verifies: