-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
ref(workflow_engine): Update workflow evaluation log data #103352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nfo to help investigate why this isn't working
…ers of trying to get debuggable output.
| return match_values(group_values=tag_values, match_value=value, match_type=match) | ||
| result = match_values(group_values=tag_values, match_value=value, match_type=match) | ||
|
|
||
| logger.debug( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is just incase the top level logs don't show me everything, i want to be able to handle the user case(s) around this specific handler.
|
|
|
@kcons 👍 love the idea. since i have typed dicts for all the snapshot stuff, i used a generic instead of 😭 -- reverted this change because of the collision with ABC + BaseModel. Can reinvestigate later, i think we'll have enough type safety through the classes now and we can push for consistency 🔜 |
3e41188 to
45508c9
Compare
Description
This PR is accomplishing two goals:
Hoping that after this, we can at least root cause any issues with the specific problematic condition handler and that we'll have enough evaluation info at the top level, that it will include all the required information for us to determine why an alert did / did not trigger. (eventually, it'd be nice if this could live in something like BigTable or Cassandra so we can query the info, reduce logging costs, and let users see the alert evaluation information if they want)