fix(dashboards): Prevent IndexError for deleted dashboard creators - #122945
Merged
Conversation
skaasten
marked this pull request as ready for review
August 28, 2026 14:21
skaasten
approved these changes
Aug 28, 2026
mjq
approved these changes
Aug 28, 2026
skaasten
enabled auto-merge (squash)
August 28, 2026 14:55
edwardgou-sentry
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an
IndexError: list index out of rangethat occurred when fetching dashboard details if the user who created the dashboard had been deleted.Root Cause:
The
DashboardDetailsModelSerializerunconditionally accessed[0]on the result ofuser_service.serialize_manywhen populating thecreatedByfield. Ifobj.created_by_idwas set but the corresponding user no longer existed,user_service.serialize_manywould return an empty list, leading to anIndexError.Solution:
get_attrs: The logic to fetch dashboard creators has been moved fromserializetoget_attrs. This allows for bulk fetching of all creator users for a list of dashboards in a singleuser_service.serialize_manycall, eliminating N+1 RPC queries.serialize: ThecreatedByfield now safely retrieves the serialized user from theattrsdictionary. If the user is not found (e.g., because they were deleted),Noneis returned forcreatedByinstead of raising anIndexError.Test Plan:
Added a unit test
test_get_created_by_is_none_when_creator_deletedtoOrganizationDashboardDetailsGetTestwhich mocksuser_service.serialize_manyto return an empty list and asserts thatcreatedByisNonein the response.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes SENTRY-5TSM
Comment
@sentry <feedback>on this PR to have Autofix iterate on the changes.This PR was automatically generated by Sentry. You can adjust this setting at any time.