feat(demangle): Import libswift demangle 6.3.1#980
Merged
Conversation
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
loewenheim
approved these changes
May 18, 2026
Dav1dde
force-pushed
the
dav1d/swift-6.3.1
branch
from
a01082c to
2d9e4e2
Compare
Brett-Best
reviewed
May 18, 2026
|
Test cases that can be added:
These currently fail and can be added. |
Member
Author
|
@Brett-Best thanks, added the tests and confirmed they fail on master. Marked them as 6.3 even though technically they could be 6.2 or anything in between, but that should be fine. Also found a solution to fix the breaking test in #981 with an additional patch. |
|
Thanks @Dav1dde, appreciate the quick turnaround once I landed in the right place :) |
Dav1dde
added a commit
that referenced
this pull request
May 19, 2026
Follow-up for the 6.3.1 upgrade in #980 restoring a removed test, which breaks with the upgrade. With the upgrade support for `MetatypeParamsRemoved` was removed from the demangler, this was previously represented with a `m` in the mangled string. This patch skips the `m` marker to keep the correctly demangle the rest of the string. This does break re-mangling of these strings, but symbolic does not expose any remangling functionality. If this patch ever becomes a problem in the future, it may be removed, it's only required for compatibility with old compiler versions and we generally prefer staying compatible with recent compilers.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #979
Refs: #913
clang -H.There is a failing test case
$s11Supercharge2AXO7ElementPAAE8elements33_35EDDAA799FBB5B74D2F426690B0D99DLL3for2asSayqd__GSo28NSAccessibilityAttributeNamea_qd__mtSo7AXErrorVYKAcDRd__lFAC3AppC_AC6WindowCTgm5which I removed, it also fails withswift demangleon the command line. Best guess right now is, that the original symbol is now mangled differently and the old version can't be de-mangled.I will do a timeboxed investigation if we can support the old mangled string, but generally we prefer supporting more recent versions over older ones.