Missing params in SearchImages and SearchVideosEditorial - #83
Merged
mapitman merged 1 commit intoAug 18, 2026
Merged
Conversation
…rameter naming in SearchImages and SearchVideosEditorial
There was a problem hiding this comment.
Pull request overview
This pull request aligns request query parameter naming with the expected API contract by renaming editorial “end date” query keys to date_to, and adds support for orientations to the videos creative search request builder.
Changes:
- Update
SearchImagesEditorialandSearchVideosEditorialto senddate_toinstead ofend_dateforwithEndDate(...). - Add
orientationssupport toSearchVideosCreative, including awithOrientation(...)builder method and request serialization. - Update and extend tests to validate the new/updated query parameters.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/searchvideoseditorialtests.js | Updates tests to expect date_to for editorial video end date queries. |
| tests/searchvideoscreativetests.js | Adds test coverage for orientations in creative video search requests. |
| tests/searchimageseditorialtests.js | Updates tests to expect date_to for editorial image end date queries. |
| lib/searchvideoseditorial.js | Renames end date query parameter from end_date to date_to. |
| lib/searchvideoscreative.js | Adds orientations state, serializes it into the query, and adds withOrientation(...). |
| lib/searchimageseditorial.js | Renames end date query parameter from end_date to date_to. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
@ChrisSimmons could you please review and merge this PR. |
ChrisSimmons
self-requested a review
August 18, 2026 15:22
mapitman
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add orientations parameter to SearchVideosCreative and update date parameter naming in SearchImages and SearchVideosEditorial