Skip to content

Missing params in SearchImages and SearchVideosEditorial - #83

Merged
mapitman merged 1 commit into
gettyimages:mainfrom
faizulhaque:add-orientations-search-videos-creative
Aug 18, 2026
Merged

Missing params in SearchImages and SearchVideosEditorial#83
mapitman merged 1 commit into
gettyimages:mainfrom
faizulhaque:add-orientations-search-videos-creative

Conversation

@faizulhaque

Copy link
Copy Markdown
Contributor

Add orientations parameter to SearchVideosCreative and update date parameter naming in SearchImages and SearchVideosEditorial

…rameter naming in SearchImages and SearchVideosEditorial
Copilot AI lite review requested due to automatic review settings August 17, 2026 23:50
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 98.093% (+0.007%) from 98.086% — faizulhaque:add-orientations-search-videos-creative into gettyimages:main

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request aligns request query parameter naming with the expected API contract by renaming editorial “end date” query keys to date_to, and adds support for orientations to the videos creative search request builder.

Changes:

  • Update SearchImagesEditorial and SearchVideosEditorial to send date_to instead of end_date for withEndDate(...).
  • Add orientations support to SearchVideosCreative, including a withOrientation(...) builder method and request serialization.
  • Update and extend tests to validate the new/updated query parameters.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/searchvideoseditorialtests.js Updates tests to expect date_to for editorial video end date queries.
tests/searchvideoscreativetests.js Adds test coverage for orientations in creative video search requests.
tests/searchimageseditorialtests.js Updates tests to expect date_to for editorial image end date queries.
lib/searchvideoseditorial.js Renames end date query parameter from end_date to date_to.
lib/searchvideoscreative.js Adds orientations state, serializes it into the query, and adds withOrientation(...).
lib/searchimageseditorial.js Renames end date query parameter from end_date to date_to.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@faizulhaque

Copy link
Copy Markdown
Contributor Author

@ChrisSimmons could you please review and merge this PR.

@ChrisSimmons
ChrisSimmons self-requested a review August 18, 2026 15:22

@ChrisSimmons ChrisSimmons left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @mapitman and @ssterli2 anything from you?

@mapitman
mapitman merged commit 9e06b7e into gettyimages:main Aug 18, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants