Skip to content

Conversation

@dariusjlukas
Copy link

Description

Prevent the user from interacting with either the attachment button or the model selector button when the chat text input is disabled.

Changes

Pass the disabled state to the file attachment's DropdownMenu Trigger and to the ModelsSelector.

Before After
Screenshot-file-attach-enabled Screenshot-file-attach-disabled

Copy link
Collaborator

@allozaur allozaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the fix! :) Just please include updated static build in the PR and then we can move forward with this.

@dariusjlukas
Copy link
Author

Hey, thanks for the fix! :) Just please include updated static build in the PR and then we can move forward with this.

Thanks for the comment. I'm assuming this is the build artifact you are referring to?
index.html.gz

@allozaur
Copy link
Collaborator

Hey, thanks for the fix! :) Just please include updated static build in the PR and then we can move forward with this.

Thanks for the comment. I'm assuming this is the build artifact you are referring to? index.html.gz

Yes, please run npm run build and push the updated tools/server/public/index.html.gz file to this PR.

@dariusjlukas
Copy link
Author

Ah, oops. I didn't realize it got committed to the repo. Should be there now.

@dariusjlukas
Copy link
Author

Hold up, something is wrong with the model selector. I'm looking into it now.

@dariusjlukas
Copy link
Author

Ok, I think the issue I was seeing was caused by a commit yesterday that disabled the model selector drop-down when running in non-router mode. This prevented the onclick callback from firing and incorrectly showed the model card button as disabled. I made a commit which should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants