-
Notifications
You must be signed in to change notification settings - Fork 14.1k
Webui: Disable attachment button and model selector button when prompt textbox is disabled. #17925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Webui: Disable attachment button and model selector button when prompt textbox is disabled. #17925
Conversation
selector button.
allozaur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for the fix! :) Just please include updated static build in the PR and then we can move forward with this.
Thanks for the comment. I'm assuming this is the build artifact you are referring to? |
Yes, please run |
|
Ah, oops. I didn't realize it got committed to the repo. Should be there now. |
|
Hold up, something is wrong with the model selector. I'm looking into it now. |
|
Ok, I think the issue I was seeing was caused by a commit yesterday that disabled the model selector drop-down when running in non-router mode. This prevented the onclick callback from firing and incorrectly showed the model card button as disabled. I made a commit which should fix this. |
Description
Prevent the user from interacting with either the attachment button or the model selector button when the chat text input is disabled.
Changes
Pass the disabled state to the file attachment's DropdownMenu Trigger and to the ModelsSelector.