CANN: CONV_TRANSPOSE_1D operator: supporting the cases where (op->src[0]->ne[0] - 1) > 255 #17934
+138
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements support for kernel_size > 255 in the CANN backend for the ggml's
CONV_TRANSPOSE_1Doperator. The existingCONV_TRANSPOSE_1Doperator, implemented via a direct call to Convolution, throws a shape error for inputs whose kernel_size is greater than 255.Summary of changes:
Added the header file
aclnnop/aclnn_slice.htoggml/src/ggml-cann/aclnn_ops.hto support slice operations.Added function implementation in
ggml/src/ggml-cann/aclnn_ops.cpp. The general approach is as follows:CONV_TRANSPOSE_1Don each small kernel with the input to obtain partial results.ggml/src/ggml-cann/ggml-cann.cpp, remove the condition check:Testing
Test steps:
./bin/test-backend-ops test -b CANN0 -o CONV_TRANSPOSE_1DAll test cases should be passed.