windows-color-fix: Changed foreground and background colors#18
Open
welnanick wants to merge 1 commit into
Open
windows-color-fix: Changed foreground and background colors#18welnanick wants to merge 1 commit into
welnanick wants to merge 1 commit into
Conversation
On windows, the 16 colors visible to the console map out like so:
0 -> backgroundColor
1 -> blue
2 -> green
3 -> cyan
4 -> red
5 -> magenta
6 -> yellow
7 -> lightWhite
8 -> lightBlack
9 -> lightBlue
10 -> lightGreen
11 -> lightCyan
12 -> lightRed
13 -> lightMagenta
14 -> lightYellow
15 -> foregroundColor
As you can see black (which maps to base02 in solarized) and white
(which maps to base2 in solarized) are not visible, meaning these colors
are missing on windows. To remedy this I changed the background colors
to base02 and foreground color to base2 to allow windows to use all 16
colors of solarized.
Contributor
Author
|
I am unable to test the effects this has on macOS and Linux machines. So I do not know if this breaks the theme for them. Obviously this is not the most visually pleasant background and foreground choices, so if there was a way to only have these changed values when running on windows, that would probably be the best. I am not a Node.js programmer, so I don't know if that is possible or how to do it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On windows, the 16 colors visible to the console map out like so:
As you can see black (which maps to base02 in solarized) and white
(which maps to base2 in solarized) are not visible, meaning these colors
are missing on windows. To remedy this I changed the background colors
to base02 and foreground color to base2 to allow windows to use all 16
colors of solarized.