macOS: fix surface focus/render state after dragging in to to another window/tab#12338
Open
bo2themax wants to merge 2 commits intoghostty-org:mainfrom
Open
macOS: fix surface focus/render state after dragging in to to another window/tab#12338bo2themax wants to merge 2 commits intoghostty-org:mainfrom
bo2themax wants to merge 2 commits intoghostty-org:mainfrom
Conversation
bo2themax
changed the title
bo2themax
force-pushed
the
fix-split-drag
branch
2 times, most recently
from
1ae49bd to
ffa6c0b
Compare
This fixes a bug: after dragging a non-focused surface from window A to window B **quickly without making B the key window**, the focused surface in window A is not receiving `keyDown` events.
…b within the same window The reason the thread is stuck is because the surface's occlusion state is set to invisible after target tab's activate while dragging, since the dragged surface is still in previous tree before dropping, and after dropping the occlusion state of this surface is not updated to visible, which causing the surface is accepting input but not rendering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 2 bugs
keyDownevents.Screen.Recording.2026-04-19.at.20.51.40.mp4
Screen.Recording.2026-04-19.at.23.15.33.mp4