macOS: restore some menu shortcuts when terminal is not focused#12522
Open
bo2themax wants to merge 7 commits intoghostty-org:mainfrom
Open
macOS: restore some menu shortcuts when terminal is not focused#12522bo2themax wants to merge 7 commits intoghostty-org:mainfrom
bo2themax wants to merge 7 commits intoghostty-org:mainfrom
Conversation
Closed
Member
Author
|
mitchellh
requested changes
May 2, 2026
Contributor
mitchellh
left a comment
There was a problem hiding this comment.
Conceptually this is totally fine, I came upon the same solution. Stylistically I think this needs to be cleaned up a bit. I feel like we could better organize some of this.
c6e5de3 to
cc9e7f9
Compare
Member
Author
1cbf728 changed the manual signal to one-time setup for first responder on key window. I hope that's what you meant, I don't want to over engineer the changes in MenuShortcutManager |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #10749.
After a few iterations for the past few weeks, this is the minimal change I can think of to fix this issue without introducing changes from the core layer.
copy,paste,select all,undoandredorestoreRegisteredMenusIfNeededfor all the native views i found that had this issue before.cutmenu and disable whenever a terminal surface is focused.Screen.Recording.2026-04-29.at.22.14.05.mp4