fix: preserve active cursor position during reflow#12598
Open
noib3 wants to merge 1 commit intoghostty-org:mainfrom
Open
fix: preserve active cursor position during reflow#12598noib3 wants to merge 1 commit intoghostty-org:mainfrom
noib3 wants to merge 1 commit intoghostty-org:mainfrom
Conversation
This PR fixes an issue where reflowing could leave the active cursor attached to a clipped trailing blank cell instead of following the current write position.
Contributor
|
This makes sense, but I wonder if we could utilize the original x/y to do this without tracked pin? Plus, since the cursor has to be in the active area I feel like there are some optimizations to be made here. |
Contributor
Author
|
I considered using simple modulo/integer division ops to get the right coordinates, but I don't think that would handle wide cells correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where reflowing could leave the active cursor attached to a clipped trailing blank cell instead of following the current write position.